fix(us-bf-088): implement updateparameters for neuralnetworkbase derived classes

[ooples]

Summary

• Implemented UpdateParameters method for EchoStateNetwork - updates output weights and bias
• Implemented UpdateParameters method for ExtremeLearningMachine - updates output layer parameters
• Implemented UpdateParameters method for HopfieldNetwork - updates weight matrix while preserving diagonal zeros
• Implemented UpdateParameters method for NEAT - updates weights of best genome connections
• Implemented UpdateParameters method for RestrictedBoltzmannMachine - updates weights and biases (visible and hidden)
• Implemented UpdateParameters method for SelfOrganizingMap - updates weight matrix

All implementations include proper parameter length validation and error handling with ArgumentException for mismatches.

Test plan

• Build the solution to verify no compilation errors
• Run unit tests if available for these neural network classes
• Verify that UpdateParameters methods correctly update internal parameters for each network type

Generated with Claude Code

[coderabbitai]

Summary by CodeRabbit

Documentation

• Standardized mathematical notation across neural network implementations to use consistent λ convention and pseudoinverse symbols.
• Corrected typographic errors and formula references in technical documentation.

Bug Fixes

• Implemented parameter update functionality for neural network models (previously unimplemented).
• Fixed capacity calculation documentation error.

Walkthrough

Changed only comments and documentation in ExtremeLearningMachine to use λ notation; implemented UpdateParameters for HopfieldNetwork and SelfOrganizingMap with input validation and weight population logic (symmetric assignment for Hopfield, row-major fill for SOM).

Changes

Cohort / File(s)	Summary
Notation & Documentation src/NeuralNetworks/ExtremeLearningMachine.cs	Replaced placeholder symbols with λ-based notation in comments and formula examples (pseudoinverse and regularization references). No changes to public API or arithmetic.
Hopfield UpdateParameters src/NeuralNetworks/HopfieldNetwork.cs	Implemented UpdateParameters(Vector<T>): validates parameter length equals (N*(N-1))/2, fills upper-triangle then mirrors to lower-triangle, sets diagonal to zero; fixed capacity documentation typo.
Self-Organizing Map UpdateParameters src/NeuralNetworks/SelfOrganizingMap.cs	Implemented UpdateParameters(Vector<T>): validates parameters length against expected weight count and writes values into internal _weights in row-major order; corrected matrix/distance/weight-update comments.

Sequence Diagram(s)

sequenceDiagram
  participant Caller as Caller
  participant Hopfield as HopfieldNetwork
  Note over Hopfield: UpdateParameters (new)
  Caller->>Hopfield: UpdateParameters(params)
  Hopfield->>Hopfield: validate length == N*(N-1)/2
  alt Invalid length
    Hopfield-->>Caller: throw ArgumentException
  else Valid
    Hopfield->>Hopfield: populate upper-triangle from params
    Hopfield->>Hopfield: mirror upper to lower, set diagonal=0
    Hopfield-->>Caller: return (void)
  end

Loading

sequenceDiagram
  participant Caller as Caller
  participant SOM as SelfOrganizingMap
  Note over SOM: UpdateParameters (new)
  Caller->>SOM: UpdateParameters(params)
  SOM->>SOM: validate length == expectedWeights (rows*cols)
  alt Invalid length
    SOM-->>Caller: throw ArgumentException
  else Valid
    SOM->>SOM: fill _weights in row-major order from params
    SOM-->>Caller: return (void)
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Review the index arithmetic in Hopfield triangle population loops for off-by-one or ordering errors.
• Verify the expected parameter count calculation for SOM matches internal weight matrix dimensions.
• Confirm no accidental changes to public signatures or numeric types occurred while adding validations.

Possibly related PRs

• test(us-if-002): add comprehensive unit tests for modelindividual class #244: Modifies UpdateParameters implementations in HopfieldNetwork and SelfOrganizingMap—touches the same methods and intent to replace stubs with functional logic.
• refactor(us-ci-018): replace empty updateparameters with invalidoperationexception in specialized networks #250: Also changes UpdateParameters behavior across neural network classes and replaces placeholder exceptions with actual implementations.

Poem

🐰 I hopped through code with pencil bright,

λ in comments, weights set right,
Symmetric rows now find their tune,
Maps filled row by row at noon—
A little rabbit celebrates this site!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title states "implement updateparameters for neuralnetworkbase derived classes," which aligns with the actual changes shown in the raw_summary. The changeset demonstrates UpdateParameters implementations for HopfieldNetwork and SelfOrganizingMap, confirming that the title accurately describes the primary objective. However, the title is somewhat broad and doesn't capture that one of the three modified files (ExtremeLearningMachine) contains only documentation updates rather than a new UpdateParameters implementation. Additionally, there is a discrepancy between the PR description (which claims implementations for six classes) and the raw_summary provided (which shows changes to only three files, with only two containing actual UpdateParameters implementations).
Description Check	✅ Passed	The PR description claims UpdateParameters implementations for six neural network classes (EchoStateNetwork, ExtremeLearningMachine, HopfieldNetwork, NEAT, RestrictedBoltzmannMachine, and SelfOrganizingMap). However, the raw_summary provided shows changes to only three files, with HopfieldNetwork and SelfOrganizingMap containing actual UpdateParameters implementations, while ExtremeLearningMachine shows only documentation and symbol notation updates. This creates a significant discrepancy between the claimed scope and the evidence in the raw_summary. The description is related to the changeset in that it discusses UpdateParameters implementations which do exist in the PR, but it appears to overstate the scope of changes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/us-bf-088-neuralnetwork-updateparameters

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ooples]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 6

🧹 Nitpick comments (2)

src/NeuralNetworks/EchoStateNetwork.cs (1)

1046-1067: ESN UpdateParameters layout looks correct; confirm vector ordering contract.

Weights are filled row‑major as W[reservoirIndex, outputIndex], then biases. This matches ComputeOutput and serialization. Please document this ordering in XML docs to avoid caller confusion and add a quick guard/assert that paramIndex == parameters.Length after assignment.

src/NeuralNetworks/SelfOrganizingMap.cs (1)

579-595: SOM UpdateParameters is sound; please document flattening.

LGTM. Add a one-liner in the XML doc stating parameters are row‑major over neurons (map cells) then input dimensions to keep callers aligned.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 129830d and 736e76f.

📒 Files selected for processing (6)

• src/NeuralNetworks/EchoStateNetwork.cs (1 hunks)
• src/NeuralNetworks/ExtremeLearningMachine.cs (4 hunks)
• src/NeuralNetworks/HopfieldNetwork.cs (1 hunks)
• src/NeuralNetworks/NEAT.cs (2 hunks)
• src/NeuralNetworks/RestrictedBoltzmannMachine.cs (2 hunks)
• src/NeuralNetworks/SelfOrganizingMap.cs (4 hunks)

🔇 Additional comments (2)

src/NeuralNetworks/ExtremeLearningMachine.cs (1)

147-154: Reasonable forwarding; add tiny safety and clarify expectations.

LGTM. Consider:

• Validate the last layer actually implements UpdateParameters semantics expected by ELM (weights-only, no biases if not present).
• Briefly document the expected flattening order the last layer consumes.

src/NeuralNetworks/RestrictedBoltzmannMachine.cs (1)

453-480: RBM parameter loading looks correct and consistent with shapes.

Weights filled as [Hidden, Visible], followed by visible and hidden biases; length check aligns with serialization. Nice.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bce9b98 and 2fd6807.

📒 Files selected for processing (3)

• src/NeuralNetworks/ExtremeLearningMachine.cs (7 hunks)
• src/NeuralNetworks/HopfieldNetwork.cs (2 hunks)
• src/NeuralNetworks/SelfOrganizingMap.cs (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/NeuralNetworks/SelfOrganizingMap.cs

🧰 Additional context used

🧬 Code graph analysis (1)

src/NeuralNetworks/ExtremeLearningMachine.cs (1)

src/Helpers/NeuralNetworkHelper.cs (1)

• ILossFunction (49-76)

🪛 GitHub Actions: Build

src/NeuralNetworks/ExtremeLearningMachine.cs

[error] 75-75: CS1003: Syntax error, ',' expected.

🪛 GitHub Actions: Quality Gates (.NET)

src/NeuralNetworks/ExtremeLearningMachine.cs

[error] 75-75: CS1003: Syntax error, ',' expected.

🪛 GitHub Check: Build All Frameworks

src/NeuralNetworks/ExtremeLearningMachine.cs

[failure] 75-75:
Identifier expected

---

[failure] 75-75:
Syntax error, ',' expected

---

[failure] 76-76:
Syntax error, ',' expected

---

[failure] 76-76:
Syntax error, ',' expected

---

[failure] 75-75:
Identifier expected

---

[failure] 75-75:
Syntax error, ',' expected

---

[failure] 76-76:
Syntax error, ',' expected

---

[failure] 76-76:
Syntax error, ',' expected

---

[failure] 75-75:
Identifier expected

---

[failure] 75-75:
Syntax error, ',' expected

🪛 GitHub Check: Publish Size Analysis

src/NeuralNetworks/ExtremeLearningMachine.cs

[failure] 76-76:
Syntax error, ',' expected

---

[failure] 76-76:
Syntax error, ',' expected

---

[failure] 75-75:
Identifier expected

---

[failure] 75-75:
Syntax error, ',' expected

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/NeuralNetworks/ExtremeLearningMachine.cs (2)

445-445: Make multiplication notation consistent.

This line uses * for multiplication, while lines 228, 260, 271, and 291 use ×. The previous review requested uniform notation throughout.

Apply this diff to align with the rest of the file:

-/// OutputWeights = (H^T * H + λI)^(-1) * H^T * T, where λ is the regularization factor, I is the identity matrix,
+/// OutputWeights = (H^T × H + λI)^(-1) × H^T × T, where λ is the regularization factor, I is the identity matrix,

---

482-482: Make multiplication notation consistent.

This line uses * for multiplication, while lines 228, 260, 271, and 291 use ×. The previous review requested uniform notation throughout.

Apply this diff to align with the rest of the file:

-// Calculate regularized pseudoinverse: (H^T * H + λI)^(-1) * H^T
+// Calculate regularized pseudoinverse: (H^T × H + λI)^(-1) × H^T

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fd6807 and 1c02c12.

📒 Files selected for processing (1)

• src/NeuralNetworks/ExtremeLearningMachine.cs (7 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/NeuralNetworks/ExtremeLearningMachine.cs (2)

src/NeuralNetworks/NeuralNetworkArchitecture.cs (4)

• NeuralNetworkArchitecture (32-805)
• NeuralNetworkArchitecture (352-376)
• NeuralNetworkArchitecture (410-425)
• NeuralNetworkArchitecture (460-474)

src/Helpers/NeuralNetworkHelper.cs (1)

• ILossFunction (49-76)

🔇 Additional comments (1)

src/NeuralNetworks/ExtremeLearningMachine.cs (1)

75-76: Constructor syntax fixed.

The nullable type marker and null-coalescing operator are now correct, resolving the critical compilation error flagged in the previous review.