Conversation
--- updated-dependencies: - dependency-name: BenchmarkDotNet dependency-version: 0.15.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
ooples
deleted the
dependabot/nuget/AiDotNetBenchmarkTests/BenchmarkDotNet-0.15.5
branch
November 3, 2025 13:02
ooples
added a commit
that referenced
this pull request
May 6, 2026
… layers + ParameterCountHelper hygiene Production-ready fixes for two major review-comment clusters: A. **Lazy-allocation pattern fix** — InitializeParameters / InitializeWeights in 7 layers was reassigning the lazy-allocated tensor field to a fresh Engine.TensorRandomXxx output, discarding the AllocateLazyWeight registration that OnFirstForward set up. This recreated the first-forward peak the streaming work is supposed to eliminate — the streamed tensor was allocated, then immediately orphaned. Fix: copy the random/init data into the existing tensor in place (AsSpan -> CopyTo) so the lazy registration stays intact. Files touched: - Conv3DLayer.cs (closes #1271.7BoE) - DiffusionConvLayer.cs (closes #1271.7BoK) - SpiralConvLayer.cs (closes #1271.7BpS) - PrimaryCapsuleLayer.cs (closes #1271.7Bo8) - RBMLayer.cs (closes #1271.7BpA) - RecurrentLayer.cs (closes #1271.7BpD) - GatedLinearUnitLayer.cs (closes #1271.7Bob) - DigitCapsuleLayer.cs (closes #1271.7BoP) B. **ParameterCountHelper hygiene**: - Class + method now `internal` rather than `public` (200 internal callers, no test or external reference). Closes #1271.7Bm6. - Removed "Closes review-comment #1271.yAXI" suffix from the production-runtime exception message — internal review tracker metadata leaking into user-visible text. Closes #1271.7BnF. Build clean on net10.0. No test changes — pattern preserved behaviour bit-for-bit; only the tensor identity / registration is fixed. Refs #296.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated BenchmarkDotNet from 0.15.4 to 0.15.5.
Release notes
Sourced from BenchmarkDotNet's releases.
0.15.5
Full changelog: https://benchmarkdotnet.org/changelog/v0.15.5.html
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)