fix: prevent docs deployment from being cancelled - #735
Conversation
Remove 'needs: build-windows' dependency from build-docs job so it starts immediately and runs in its own concurrency group (pages). The issue was that when multiple commits are pushed to master quickly, the main workflow's cancel-in-progress: true setting would cancel the entire workflow before build-docs could complete. Since build-docs has its own concurrency group with cancel-in-progress: false, removing the dependency allows it to run independently and complete even when the main workflow is cancelled by a newer commit. The docs job builds from source anyway, so it doesn't need build-windows. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughDecoupled the build-docs job from Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where documentation deployment was consistently being cancelled due to workflow concurrency settings. When multiple commits are pushed to master quickly, the workflow's cancel-in-progress: true setting causes newer runs to cancel older ones, preventing the documentation job from completing.
Changes:
- Removed the
needs: build-windowsdependency from thebuild-docsjob to allow it to run independently - Added explanatory comments documenting why the job doesn't need to wait for the build-windows job
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add step to remove pre-installed software that's not needed for docs: - Old .NET versions (6.x, 7.x) - Android SDK - GHC (Haskell) - CodeQL - Chromium - PowerShell This frees up ~20GB+ of disk space to prevent "no space left on device" errors during the documentation build. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Fixes documentation deployment which has never successfully completed due to multiple issues.
Issues Fixed
1. "No space left on device" error
The Ubuntu runner runs out of disk space while building DocFX docs and Blazor Playground. Added a cleanup step that removes ~20GB+ of pre-installed software we don't need:
2. Job dependency causing cancellation (already fixed but kept the note)
The
needs: build-windowsdependency was removed so the docs job can run independently in its own concurrency group.Changes
needs: build-windowsdependency from build-docs jobAfter this merge
The next push to master should successfully deploy:
Test plan
Build & Deploy Documentationjob completes successfullyGenerated with Claude Code