test: add comprehensive Diagnostics integration tests - #777
Merged
Merged
Conversation
Add 98 integration tests for the Diagnostics module covering: MemoryTracker: - Enable/disable functionality - Snapshot creation and comparison - History tracking - Reset functionality - Memory pressure level detection - Memory estimation ProfilerSession: - Enable/disable functionality - Scope-based profiling - Timer-based profiling - Reset functionality - Report generation - Statistics calculation ProfileReport: - JSON/CSV/Markdown export - Report comparison - Operation statistics Integration scenarios: - Memory tracking during allocations - Profiling during simulated workloads - Combined memory and profiler usage Fixes #653 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughA comprehensive integration test suite for the Diagnostics module is introduced, validating MemoryTracker, MemorySnapshot, MemoryDiff, MemoryPressureLevel, ProfilerSession, ProfilingConfig, and profiling report generation across multiple formats, statistics computation, profile comparison, and multi-threaded scenarios. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
3 tasks done
ooples
pushed a commit
that referenced
this pull request
Jul 19, 2026
…t NHWC) Engine.GridSample is uniformly NCHW (PyTorch F.grid_sample convention, standardized in Tensors #777): both CPU overloads, the GPU override, and GridSampleGpu all take [N,C,H,W] and return [N,C,outH,outW]. All seven callers wrongly permuted their image/feature input to NHWC before sampling (a stale assumption from when the engine was NHWC, flipped by #777), which re-labelled the H dim as "channels". Most passed loose invariants with geometrically-wrong warps; BasicVSR++/SpyNet threw IndexOutOfRange at the degenerate 2x2 pyramid level (3-channel frame warped into 2 "channels"). Fix: pass the channels-first tensor directly; the grid is [B,outH,outW,2] regardless of image layout, so it is unchanged. SpatialTransformer's CPU and GPU forward paths are reworked to channels-first (localization reduces over the channel axis; output permuted to NHWC only for channel-last callers). SpyNet also drops its redundant private _engine (which pinned it to CpuEngine) in favour of the base LayerBase.Engine property. Verified (net10.0, GPU disabled): BasicVSR++ 27/27, FILM 27/27, RIFE 27/27, UPRNet 27/27, RAFT 27/27, SpyNet 10/10, SpatialTransformer 10/10. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ooples
pushed a commit
that referenced
this pull request
Jul 19, 2026
…t NHWC) Engine.GridSample is uniformly NCHW (PyTorch F.grid_sample convention, standardized in Tensors #777): both CPU overloads, the GPU override, and GridSampleGpu all take [N,C,H,W] and return [N,C,outH,outW]. All seven callers wrongly permuted their image/feature input to NHWC before sampling (a stale assumption from when the engine was NHWC, flipped by #777), which re-labelled the H dim as "channels". Most passed loose invariants with geometrically-wrong warps; BasicVSR++/SpyNet threw IndexOutOfRange at the degenerate 2x2 pyramid level (3-channel frame warped into 2 "channels"). Fix: pass the channels-first tensor directly; the grid is [B,outH,outW,2] regardless of image layout, so it is unchanged. SpatialTransformer's CPU and GPU forward paths are reworked to channels-first (localization reduces over the channel axis; output permuted to NHWC only for channel-last callers). SpyNet also drops its redundant private _engine (which pinned it to CpuEngine) in favour of the base LayerBase.Engine property. Verified (net10.0, GPU disabled): BasicVSR++ 27/27, FILM 27/27, RIFE 27/27, UPRNet 27/27, RAFT 27/27, SpyNet 10/10, SpatialTransformer 10/10. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
MemoryTracker (24 tests)
MemorySnapshot & MemoryDiff (12 tests)
ProfilerSession (25 tests)
ProfileReport (20 tests)
Integration Scenarios (17 tests)
Test Results
Fixes #653
🤖 Generated with Claude Code