Skip to content

fix(tests): pass --no-compile to pip in python integration tests - #188

Merged
jsteinich merged 1 commit into
open-constructs:mainfrom
X-Guardian:chore/fix-flaky-python-tests
May 18, 2026
Merged

jsteinich merged 1 commit into
open-constructs:mainfrom
X-Guardian:chore/fix-flaky-python-tests

Conversation

@X-Guardian

@X-Guardian X-Guardian commented May 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

pip install -r requirements.txt in the provider-add and provider-upgrade Python integration tests has been flaking with AssertionError: assert os.path.exists(pyc_path) from pip's wheel installer, mid-install of the JSII-generated cdktn / cdktn-provider-local wheels.
The assert fires in pip's .pyc byte-compilation step (cpython#86612 / bpo-42446) — pip expects a .pyc next to every .py, but compileall skips files under certain Python build configurations, leaving pip's assert with nothing to find.

Example failed job: https://github.com/open-constructs/cdk-terrain/actions/runs/26030565831/job/76518367284?pr=160

Fix

These tests only read/write requirements.txt to assert that cdktn provider add / cdktn provider upgrade edits it correctly — they never execute the installed packages. Passing --no-compile skips the bytecode step entirely and removes the failure mode without changing what's being tested.

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@X-Guardian
X-Guardian marked this pull request as ready for review May 18, 2026 16:19
@X-Guardian
X-Guardian requested a review from a team as a code owner May 18, 2026 16:19
@jsteinich
jsteinich merged commit da67ea9 into open-constructs:main May 18, 2026
381 checks passed
jsteinich added a commit that referenced this pull request May 26, 2026
## 0.23.2

### chore
- chore: Update npm version to support OIDC trusted publishing
[\#205](#205)
- chore: Fix publib running to use npx rather than yarn
[\#203](#203)
- chore(tests): Add test for Node type stripping
[\#198](#198)
- chore(gha): Enable NPM OIDC Publishing
[\#195](#195)
- chore: remove mention of Hashicorp support
[\#193](#193)
- chore: consolidate release workflows for npm OIDC
[\#192](#192)
- chore: tell users to search for cdktn on npm
[\#185](#185)
- chore: replace cdk.tf/modules-and-providers links
[\#184](#184)
- chore: fix references to cdktf in TS examples
[\#183](#183)
- chore: point to correct docs repo
[\#181](#181)
- chore: delete Vercel config for cdk.tf site
[\#180](#180)
- chore(gha): optimise integration & provider-integration CI pipelines
[\#178](#178)
- chore(gha): optimise examples CI pipeline
[\#175](#175)
- chore: migrate jest to @nx/jest plugin with swc-jest
[\#160](#160)
- chore: replace yazl with fflate
[\#148](#148)
- chore(lib): Move cdktn package to src/ and lib/ layout
[\#145](#145)
- chore: Consolidate PR CI into tiered orchestrator workflow
[\#143](#143)

### fix

- fix(gha): Need to grant permission on workflow call job
[\#196](#196)
- fix(cli): Fix input getting split between cdktn and Terraform
[\#191](#191)
- fix(cli): restore non-bundled dependencies
[\#190](#190)
- fix: Configurable dist artifact name to fix release workflows
[\#189](#189)
- fix(tests): pass --no-compile to pip in python integration tests
[\#188](#188)
- fix(cli): pass languageOptions to `get`
[\#179](#179)
- fix(provider-generator): add missing semicolons
[\#177](#177)

### feat

- feat(provider-generator): configurable import extensions
[\#151](#151)
@github-actions

Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants