Skip to content

fix(tests): mark the terraform-cloud target Terraform-only in the matrix #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsteinich merged 2 commits into from
Sep 14, 2026
Merged

fix(tests): mark the terraform-cloud target Terraform-only in the matrix #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be80c0
fix(tests): mark the terraform-cloud target Terraform-only in the matrix
jsteinich Sep 12, 2026
30d56d1
fix(tests): fail closed when a matrix config key matches no target
jsteinich Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tools/build-test-matrix.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,17 @@ const pinnedRuntimes = {
],
};

/**
* Targets that only ever run under Terraform. Checked against the resolved runtimes below, so a pin and a future
* non-Terraform default axis both trip it.
*
* @type {Set<string>}
*/
const terraformOnly = new Set([
// HCP Terraform's workspace API pins a Terraform version and has no OpenTofu equivalent.
"typescript/terraform-cloud/test.ts",
]);

for (const [target, runtimes] of Object.entries(pinnedRuntimes)) {
for (const { product, version } of runtimes) {
if (!availableVersions[product]?.includes(version)) {
Expand Down Expand Up @@ -78,6 +89,15 @@ const targets = absoluteTargets
.map((p) => (p.startsWith(testDirPrefix) ? p.slice(testDirPrefix.length) : p))
.sort();

// A key that matches no target would make the guards below silently inert.
for (const key of [...Object.keys(pinnedRuntimes), ...terraformOnly]) {
if (!targets.includes(key)) {
throw new Error(
`"${key}" is configured in pinnedRuntimes or terraformOnly but is not a discovered test target.`,
);
}
}

/**
* Matches test files that exercise the HCL synth path with real assertions. Keep in sync with the HCL-positive
* decorators exported by `test/test-helper.ts`.
Expand Down Expand Up @@ -109,6 +129,11 @@ for (const target of targets) {
pinnedRuntimes[target] ??
tfVersions.map((version) => ({ product: "terraform", version }));
for (const { product, version } of runtimes) {
if (product !== "terraform" && terraformOnly.has(target)) {
throw new Error(
`${target} is Terraform-only, but the matrix resolved it to ${product} ${version}.`,
);
}
for (const hclOutput of modes) {
include.push({
target,
Expand Down
Loading