[jsteinich]

Related issue

Fixes #4

Description

• Built a simple interactive process wrapper that makes use of cross-spawn with the inherit option for stdin
• Replaced exiting pty-process wrapper with new interactive-process wrapper
• Replaced direct node-pty usage with cross-spawn usage
• Removed references to node-pty

Checklist

• I have updated the PR title to match CDKTN's style guide
• I have run the linter on my code locally
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation if applicable
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works if applicable
• New and existing unit tests pass locally with my changes

[commiterate]

node:child_process v. cross-spawn (since it wasn't clear to me what cross-spawn actually does from its README): sindresorhus/execa#578 (comment)

Since CDKTF was already using it (and thus CDKTN as well), this is fine in the short to medium term.

Long term I'm less sure because cross-spawn seems unmaintained and there's some concerning issues like moxystudio/node-cross-spawn#175.

I'm not completely sure which parts of cross-spawn are important to CDKTN. It looks like:

• cdktn invocations already split arguments (e.g. spawn("cdktn", ["watch", "--auto-approve"]).
• Using spawn(..., { shell: process.platform === 'win32' }) seems fine for this use case specifically (automatically toggles quoting/escaping and PATHEXT is handled by the Windows shell).

[jsteinich]

node:child_process v. cross-spawn (since it wasn't clear to me what cross-spawn actually does from its README): sindresorhus/execa#578 (comment)

Since CDKTF was already using it (and thus CDKTN as well), this is fine in the short to medium term.

Long term I'm less sure because cross-spawn seems unmaintained and there's some concerning issues like moxystudio/node-cross-spawn#175.

I'm not completely sure which parts of cross-spawn are important to CDKTN. It looks like:

• cdktn invocations already split arguments (e.g. spawn("cdktn", ["watch", "--auto-approve"]).
• Using spawn(..., { shell: process.platform === 'win32' }) seems fine for this use case specifically (automatically toggles quoting/escaping and PATHEXT is handled by the Windows shell).

I used it here primarily because it was used elsewhere in the project, but I do suspect that some of the cross platform issues do come up.

At least of the portion of the Windows tests are currently disabled in CI. Would be nice to have them running before attempting to move away from cross-spawn, though I could run them locally on WIndows to check.

[commiterate]

Sounds good. Dropping cross-spawn can be tracked separately.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.