refactor: move OTel hooks to openfeature.contrib.hook - #64
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 90.55% 93.05% +2.50%
==========================================
Files 8 9 +1
Lines 180 216 +36
==========================================
+ Hits 163 201 +38
+ Misses 17 15 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
federicobond
force-pushed
the
refactor/hook
branch
from
March 11, 2024 01:05
11e418c to
55ed930
Compare
beeme1mr
approved these changes
Mar 11, 2024
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
refactor/hook
branch
from
March 11, 2024 02:28
55ed930 to
16db9be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
openfeature.contrib.hooknamespace, to match the hook namespace in the Python SDK. See chore(main): release openfeature-hooks-opentelemetry 0.1.1 #53 (comment)Keeps the symmetry between the main and contrib repo namespaces.