Skip to content

chore(main): release openfeature-hooks-opentelemetry 0.1.1 - #53

Merged
federicobond merged 1 commit into
mainfrom
release-please--branches--main--components--openfeature-hooks-opentelemetry
Mar 13, 2024
Merged

chore(main): release openfeature-hooks-opentelemetry 0.1.1#53
federicobond merged 1 commit into
mainfrom
release-please--branches--main--components--openfeature-hooks-opentelemetry

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

0.1.1 (2024-03-11)

📚 Documentation

  • update OpenTelemetry hook README (#49) (02157f4)

🔄 Refactoring

  • move OTel hooks to openfeature.contrib.hook (#64) (7075656)

This PR was generated with Release Please. See documentation.

@github-actions
github-actions Bot requested a review from a team as a code owner February 23, 2024 19:14
@federicobond

Copy link
Copy Markdown
Member

Last minute check: so we want to put our hooks under opentelemetry.contrib.hooks or opentelemetry.contrib.hook?

@github-actions
github-actions Bot force-pushed the release-please--branches--main--components--openfeature-hooks-opentelemetry branch from 47a0692 to 2512edf Compare February 24, 2024 00:24
@beeme1mr

Copy link
Copy Markdown
Member

Last minute check: so we want to put our hooks under opentelemetry.contrib.hooks or opentelemetry.contrib.hook?

I think hooks plural is fine this this case. That's in line with the JS OTel hook. We did this because the hook bundled a trace hook and a metrics hook in the same artifact.

FYI @toddbaert

@federicobond

Copy link
Copy Markdown
Member

That's indeed a good reason for keeping the PyPI package name as openfeature-hooks-opentelemetry. I liked the symmetry between the openfeature.hook and openfeature.contrib.hook namespaces though, matching something we already do with providers, where built-in providers are in openfeature.provider and contrib providers are in openfeature.contrib.provider.

@toddbaert

Copy link
Copy Markdown
Member

That's indeed a good reason for keeping the PyPI package name as openfeature-hooks-opentelemetry. I liked the symmetry between the openfeature.hook and openfeature.contrib.hook namespaces though, matching something we already do with providers, where built-in providers are in openfeature.provider and contrib providers are in openfeature.contrib.provider.

There was some discussion in the .NET contribs about removing the .contibs segment from the namespace, which we might want to consider, but I think either route is fine, and since nothing is 1.0, can be changed later if we really regret it.

@github-actions
github-actions Bot force-pushed the release-please--branches--main--components--openfeature-hooks-opentelemetry branch from 2512edf to f5befb7 Compare March 11, 2024 01:09
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
@github-actions
github-actions Bot force-pushed the release-please--branches--main--components--openfeature-hooks-opentelemetry branch from f5befb7 to 76b659f Compare March 11, 2024 02:30
@federicobond

Copy link
Copy Markdown
Member

Not sure why it has not triggered the build for sast 🤔

@gruebel

gruebel commented Mar 11, 2024

Copy link
Copy Markdown
Member

Not sure why it has not triggered the build for sast 🤔

yeah, definitely strange...

@beeme1mr beeme1mr closed this Mar 13, 2024
@beeme1mr beeme1mr reopened this Mar 13, 2024
@codecov

codecov Bot commented Mar 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (d8e10c7) to head (76b659f).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   90.55%   93.05%   +2.50%     
==========================================
  Files           8        9       +1     
  Lines         180      216      +36     
==========================================
+ Hits          163      201      +38     
+ Misses         17       15       -2     
Flag Coverage Δ
unittests 93.05% <ø> (+2.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@federicobond
federicobond merged commit 130d5c3 into main Mar 13, 2024
@federicobond
federicobond deleted the release-please--branches--main--components--openfeature-hooks-opentelemetry branch March 13, 2024 01:50
@github-actions

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants