Repository navigation
Conversation
proost
marked this pull request as ready for review
September 12, 2026 06:18
…ntrib into refactor-remove-gyp-and-python2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GYP and python2 both are not maintained. Also python2 is one of blocker for future os version update. Because lots of legacy dependencies needed to install. So it makes difficult to maintain this module.
I choose CMake, because this project and otel-cpp standard also most C/C++ project does.
I want to step by step changes. easy to review, easy to track what is changes.