Skip to content

ci: skip the changelog check for dependabot - #5227

Merged
herin049 merged 2 commits into
open-telemetry:mainfrom
ocelotl:issue_5226_changelog_excludes_dependabot
Oct 26, 2026
Merged

herin049 merged 2 commits into
open-telemetry:mainfrom
ocelotl:issue_5226_changelog_excludes_dependabot

Conversation

@ocelotl

@ocelotl ocelotl commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #5226, which carries the definitions and the full measurement.

The changelog job excludes otelbot[bot] and says nothing about dependabot[bot]. Dependabot writes no changelog fragment and does not apply the Skip Changelog label to its own pull requests, so the check fails on every Dependabot pull request and stays failed until a maintainer applies the label by hand.

This adds one line after .github/workflows/changelog.yml:23, so that the condition names the same two accounts .github/workflows/check-links.yml:36 already names:

    if: |
      github.event_name != 'merge_group' &&
      !contains(github.event.pull_request.labels.*.name, 'Skip Changelog')
      && github.actor != 'otelbot[bot]'
      && github.actor != 'dependabot[bot]'

Measured on 25 October 2026:

Count
Open pull requests opened by dependabot[bot] 17
...of those, with a failing changelog check 16
Merged pull requests opened by dependabot[bot] 22
...of those, carrying a hand-applied Skip Changelog label 21

The oldest failing one is #4849, open since 22 July 2026.

A Dependabot pull request raises a pinned version in a requirements file or in uv.lock. It publishes no distribution and alters the behaviour of no released one, which is the case the Skip Changelog label exists for, so the exclusion produces the same outcome the maintainers already produce by hand, 21 times out of 22.

This matters more once #5220 is fixed. #5221 and #5223 together unblock 344 Dependabot alerts, and every security update Dependabot opens after that would arrive with a red changelog check waiting for a hand-applied label.

No changelog fragment here, for the same reason it does not apply to Dependabot: this changes the behaviour of no released distribution. The Skip Changelog label applies.

The changelog job excludes otelbot[bot] but says nothing about
dependabot[bot]. Dependabot writes no changelog fragment and does not
apply the Skip Changelog label to its own pull requests, so the check
fails on every one of them and stays failed until a maintainer applies
the label by hand.

16 of the 17 open Dependabot pull requests are failing the check, the
oldest since 22 July 2026, and 21 of the 22 merged ones carry a
hand-applied Skip Changelog label.

.github/workflows/check-links.yml already excludes both accounts.
@ocelotl
ocelotl requested a review from a team as a code owner October 25, 2026 22:32
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 25, 2026
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-26 00:41 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@github-project-automation github-project-automation Bot moved this to Approved PRs in Python PR digest Oct 25, 2026
@herin049
herin049 enabled auto-merge October 26, 2026 00:31
@herin049
herin049 added this pull request to the merge queue Oct 26, 2026
Merged via the queue into open-telemetry:main with commit ae7865b Oct 26, 2026
770 checks passed
@github-project-automation github-project-automation Bot moved this from Approved PRs to Done in Python PR digest Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

The changelog workflow excludes otelbot but not dependabot, so every Dependabot pull request fails the changelog check

2 participants