Repository navigation
test(urllib): increase est_value_delta in duration assertions to fix flaky test on PyPy - #5273
Open
VimalN2005 wants to merge 2 commits into
Open
VimalN2005 wants to merge 2 commits into
VimalN2005 wants to merge 2 commits into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-31 18:11 UTC Review the latest changes. Status above doesn't look right?
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5180
In
TestUrllibMetricsInstrumentation,assert_metric_expectedusesest_value_delta=40for duration metric comparisons. On PyPy environments and heavily loaded CI runners, the overhead of PyPy's JIT compilation and timer measurement jitter on the initial request often exceeds 40ms (for instance, recording52.4mswhile estimation measures higher), resulting in intermittent test failures in CI.Align the duration estimation tolerance with other instrumentation tests in this repository (such as
celeryandtornado), which useest_value_delta=200to reliably accommodate JIT warmup without sacrificing duration verification.Type of change
Checklist: