Repository navigation
refactor(plugin): replace language parsers with source previews - #1391
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a02e1c1476
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
zcrab-oai
left a comment
There was a problem hiding this comment.
Reviewed the diff and relevant surrounding code at 6aa9d8a, with an independent second pass. No obvious correctness or regression issues found. Full local platform suites were not rerun. CI still has failed, canceled, or unfinished checks; those results remain separate from this source-review approval.
9abc6d7 to
736e787
Compare
59a35fc to
fbd4d81
Compare
736e787 to
3dd9a07
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fbd4d81 to
e401dda
Compare
Summary
Helpers that build file inventories include short source previews. Their language-specific parsers can discard useful context: a small Python handler becomes only a function signature, and a configuration setting loses its value. Use bounded source text for every file instead, removing the need to maintain those parsers.
Builds on #1347, which is now merged.
Changes
Testing
On the rebased head:
git range-diffconfirms that both preview commits retain identical patches after rebasing onto main following the merge of fix(plugin): include text files in scans regardless of extension #1347.Repeat the focused Python checks from
plugins/codex-security:With dependencies and the verified native build artifact installed, repeat the SDK checks from
sdk/typescript:pnpm run build:plugin bun test --timeout 30000 tests-ts/diff-rank-input.test.ts tests-ts/compact-diff-scan.test.ts tests-ts/custom-validation.test.tsNo model-quality benchmark was run on this PR head.
Risk and rollout
Helper commands, JSONL fields, binary handling, read limits, and preview byte budgets remain compatible. Small files retain bodies and values. Large-file samples still omit and truncate lines, so they can expose fewer declarations than structural outlines and do not replace reading the file.
Standard, compact diff, and Deep discovery do not use ranking previews to choose files. Direct helper users see the changed preview content; the legacy diff workflow still copies every selected row into full-file review. Before using previews to select scan coverage, compare discovery recall and false positives on large files, templates, and unfamiliar extensions. No CLI flags or migration are required.
Public disclosure review