Repository navigation
fix: validate code evidence paths - #1567
Conversation
mldangelo-oai
left a comment
There was a problem hiding this comment.
The added pattern rejects supported POSIX source names in both finalization and sealed loading. Please preserve the existing source-path contract when applying it to code evidence.
mldangelo-oai
left a comment
There was a problem hiding this comment.
Code evidence now uses the existing SDK path policy, preserving valid colon-containing filenames and sealed bytes. The producer and reader regression checks pass.
mldangelo-oai
left a comment
There was a problem hiding this comment.
The code-evidence validation preserves valid filenames and sealed text. Publication coverage now verifies both unsafe-path rejection and unchanged snippets for valid paths without source links. The 121 focused contract/publication tests, type checks, formatting, and portable checks pass.
Summary
The SDK could load unsafe
codeEvidence[].pathvalues in sealed scans even though the Python producer rejects them. Apply the existing canonical source-path policy while preserving valid POSIX filenames. Addresses #541.Changes
Testing
build:ci, source compatibility checker, and its 9 Node tests.Risk and rollout
No public CLI changes. Unsafe code-evidence paths now fail SDK loading, matching producer behavior. Previously supported POSIX filenames and sealed path spellings remain accepted.
Public disclosure review