Repository navigation
fix(workbench): serialize registrations with archival - #1587
Merged
mldangelo-oai merged 4 commits intoOct 13, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
There was a problem hiding this comment.
🟢 Approval recommended
The focused synchronization fix preserves existing behavior and has appropriate regression coverage.
0 open findings
What changed in this PR
Serializes output-directory validation with archive transactions to prevent misleading errors during concurrent registrations.
Changes:
- Defers host-managed archive validation until writer admission.
- Preserves early validation for non-moving registrations.
- Adds a deterministic concurrency regression test.
| File | Description |
|---|---|
plugins/codex-security/scripts/workbench_db.py |
Moves archive-directory validation inside the writer transaction when required. |
plugins/codex-security/tests/test_workbench_archive.py |
Tests concurrent registration during archive rename and recreation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…/codex/simplify-pr-1587
mldangelo-oai
deleted the
mdangelo/codex/scan-registration-serialization
branch
October 13, 2026 01:41
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait for the existing database writer before inspecting an output directory that registration may archive.
Changes
Testing
All 29 recorded archive/registration tests and the five required portable checks passed. The regression fails against the original code with the missing-directory error.
Risk and rollout
The change uses the existing writer transaction and canonical-directory validation. Non-archiving calls retain their existing error ordering, and archive rollback and artifact retention remain covered by the tests.
Public disclosure review