Skip to content

fix(action): describe positive numeric input bounds - #1605

Merged
mldangelo-oai merged 2 commits into
openai:mainfrom
WenJing95:fix/action-input-bounds
Oct 19, 2026
Merged

mldangelo-oai merged 2 commits into
openai:mainfrom
WenJing95:fix/action-input-bounds

Conversation

@WenJing95

Copy link
Copy Markdown
Contributor

Summary

max-cost and max-time-hours use Number.MIN_VALUE as the lower bound, and max-cost has no upper bound. So max-cost: 0 failed with max-cost must be a number between 5e-324 and Infinity.

Changes

These inputs now say must be a positive number, plus no greater than 96 for max-time-hours to match the SDK. Tests check the full messages, and dist/index.cjs is rebuilt.

Testing

Tests pass.

Risk and rollout

Error text only.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errors now describe the documented bounds without changing accepted inputs. Action validation passes, and the rebuilt bundle reports the same clearer messages.

@github-actions github-actions Bot added the bug Something isn't working label Oct 19, 2026
@mldangelo-oai
mldangelo-oai merged commit f61dfd9 into openai:main Oct 19, 2026
58 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants