Skip to content

chore(plugin): clean up imports and expected test exceptions - #1665

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/quality-source-cleanup
Oct 17, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/quality-source-cleanup

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Remove unused imports and clarify Python imports and the expected exception in an archive concurrency test, preserving production behavior.

Changes

  • Remove unused schema and error-helper imports from the MCP app.
  • Import ctypes.wintypes and unittest.mock consistently while retaining their existing local names.
  • Catch the expected SystemExit in the archive registration test instead of every BaseException.

Testing

Passed:

  • Ruff 0.16.10 check and format check over plugins/codex-security using its pyproject.toml.
  • pnpm --dir sdk/typescript run build:ci.
  • node .github/scripts/check_plugin_source_compatibility.mjs.
  • node --test .github/scripts/test_check_plugin_source_compatibility.mjs (9 tests).
  • MCP app typecheck, generated-schema freshness, and formatting checks for the changed TypeScript files.
  • Focused artifact-discovery and Deep Scan coordinator tests.
  • Focused Python timestamp, archive, and Windows-file tests: 26 passed, 33 subtests passed; 5 Windows-only tests skipped on macOS.
  • Bundled plugin build, using the native artifact from CI for the unchanged native source revision.
  • Two independent native code reviews and an independent verification pass, with no actionable findings.

Risk and rollout

Small behavior-preserving cleanup. The Python imports retain their existing bindings, and the exception change only affects a test that expects SystemExit. Windows-specific behavior still needs the normal Windows CI coverage.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T05:06:01.211048Z f41305f PR opened
🔒 Security Review ✅ Completed 2026-10-16T05:07:09.239340Z f41305f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai
mldangelo-oai merged commit 83564c9 into main Oct 17, 2026
65 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/quality-source-cleanup branch October 17, 2026 18:00
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant