Repository navigation
refactor(sdk): import schema APIs directly from Zod - #1726
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDK schema modules import Zod through the CLI framework, which unnecessarily initializes Incur when loading the SDK. Import Zod directly from the SDK's existing dependency.
Changes
Switch the Zod imports in finding import, Cloud publication, and host protocol modules to
zod. Schemas and dependency versions stay unchanged.Testing
pnpm run types,pnpm run format,pnpm run build:ci, andpnpm run build: passed.12345and1187573209): each had 4,899 passed, 65 skipped, 11 failed. All failures stop at Git-root discovery because of a pre-existing invalid Git marker above the local checkout. The affected files are unchanged from the base, and all 11 cases pass on Linux, macOS, and Windows in this PR's CI run.pnpm pack,pnpm run check:package <archive>, andpnpm run test:package <archive>: passed, including installed SDK imports, NodeNext types, CLI lifecycle, hosted protocol, and Deep worker/restart smoke checks.Risk and rollout
Low-risk dependency cleanup with no public API, CLI, schema, or dependency-version changes. The lockfile resolves both import paths to Zod 4.6.5.
Public disclosure review