Skip to content

refactor!: stop writing coverage.json - #1762

Open
ianw-oai wants to merge 6 commits into
mainfrom
codex/remove-coverage-artifact
Open

ianw-oai wants to merge 6 commits into
mainfrom
codex/remove-coverage-artifact

Conversation

@ianw-oai

@ianw-oai ianw-oai commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

New scans no longer write coverage.json. Its name suggested a measured percentage of files reviewed, but it held review and recovery bookkeeping. The manifest and checkpoints now hold the data needed to validate results and resume work.

Changes

Update the CLI, SDK, MCP tools and GitHub Action to use the manifest. Older saved scans remain readable.

Testing

Build, types, formatting, source checks and Action bundle verification passed. Recovery, finalization and custom validation checks passed after fixture fixes and reruns. A worker timing test and a Linux-only Action test fail locally. The full SDK suite was not completed. CI is running.

Risk and rollout

Breaking change: results use review instead of coverage, draft inputs use reviewState, and SDK coveragePath is removed. Release the SDK, plugin and Action together. Keep coverage.json in older saved scans.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the breaking-change Breaking change called out in generated release notes label Oct 19, 2026
Comment thread github-action/src/results.ts Fixed
Comment thread github-action/tests/results.test.ts Fixed
@ianw-oai ianw-oai changed the title refactor!: replace coverage artifacts with review state refactor!: stop writing coverage.json Oct 19, 2026
@ianw-oai
ianw-oai marked this pull request as ready for review October 19, 2026 20:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-19T21:59:05.387534Z e781f66 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Can you see if you can simplify this a bit? Would be great if it removed net lines of code instead of adding them

Comment thread plugins/codex-security/mcp-app/src/artifact-scan-draft.ts Fixed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Breaking change called out in generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants