Repository navigation
fix(skill): allow readable interactive verification results - #1836
Merged
mldangelo-oai merged 4 commits intoOct 23, 2026
Merged
Conversation
mldangelo-oai
approved these changes
Oct 23, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
I reproduced the forced JSON response with the old skill, then tested this version through real Codex conversations. Ordinary requests now produce readable Markdown, an explicit JSON request still matches the existing contract, and fixed and unfixed cases both receive the correct verdict. The source trees stayed unchanged throughout.
I also checked the CLI and hosted callers, ran real Standard and bounded Deep scans with both fixes applied, and validated the final composition with current main. This changes the presentation without weakening the verification or evidence requirements. The small, focused change looks good to merge.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1830. Interactive
verify-fixconversations now default to readable Markdown with a verdict, source evidence, and proof gaps for each finding. Explicit JSON requests and automated result contracts retain the existing JSON shape.Changes
Testing
Approved head:
265c3b9c610c5d5ef351979ad9ca39cae4970666.still_vulnerable.53da0ecc80df21d69a7a264539f1a2352764fe75passed the required portable checks in order: Ruff lint, Ruff formatting, SDKbuild:ci, plugin source compatibility, and all nine source-checker tests. Plugin and SDK builds, types/generated-file checks, formatting, andgit diff --checkpassed.2887100861).e1dd428df151b669297b4642b59133dfce92a2c8: 49 successful jobs, one skipped.Risk and rollout
Interactive responses change format. Automated JSON output, verdict criteria, evidence requirements, and the read-only boundary remain unchanged. Live QA ran on Linux; hosted CI also covers Windows and macOS. The Deep QA run was bounded to two discovery rounds, not an exhaustive assessment of the fixture.
Public disclosure review