Repository navigation
fix(plugin): persist large scan usage at completion and failure - #1874
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for fixing large usage persistence. Reviewed both changed files and the completion, failure, usage-reconciliation and cost-limit paths; no actionable issue. Removing the size ceiling preserves the existing usage validation and scan ownership checks.
Fresh checks, builds, types, formatting, 19 focused usage tests and the new failure-state regression passed. Independent base/head controls confirmed large valid records remain intact and malformed records remain rejected. The two completion regressions hit the unchanged ownership guard locally; current hosted macOS CI separately passed all 151 scan-usage cases, including all three new regressions.
Summary
Valid scan usage above 8 KiB could prevent completion or failure from being recorded, leaving a scan marked as running. Remove the serialized-size ceiling so terminal state and complete usage are saved together.
Changes
Testing
build:ci, portable source compatibility, and its nine regression tests.git diff --checkpassed.Risk and rollout
The change accepts larger valid usage records without changing their schema or scan ownership requirements. User-selected cost limits remain enforced. No migration or new configuration is required.
Public disclosure review