Repository navigation
fix(import): preserve complete local vendor evidence - #1886
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for preserving complete local vendor evidence while keeping Cloud validation intact. No material findings at 8617c98533d0be8590ca449907d224ed5305912c. Builds, types and formatting passed; 382 local tests and 30 additional reader/storage/boundary controls passed. The local adapter run also had 57 publication failures: 54 explicitly hit the filesystem-owner guard, and three had downstream failures consistent with that path. All 57 test identities pass in independently verified CI artifacts for this exact source, along with all 23 new persistence and validation cases. The additional SQLite controls cover storage components; the guarded end-to-end path was verified through hosted tests. CI still has pending checks, and native Windows execution is not claimed.
Summary
Local vendor imports can discard valid findings because their readers apply Cloud publication limits. Local imports now retain complete evidence and source identities while Cloud publication continues to enforce its existing payload contract.
Changes
Testing
Risk and rollout
Local imports may retain larger records and use correspondingly more memory and disk space. Existing reader defaults and Cloud payload limits are preserved; malformed evidence, unsafe paths or links, conflicting source identities, and repository mismatches remain rejected. No CLI flags, database migrations, duration limits, or archive limits change. Native Windows execution has not been performed locally.
Public disclosure review