Skip to content

fix(wiz): preserve unrated vulnerability severity on import - #1898

Merged
mldangelo-oai merged 4 commits into
openai:mainfrom
WenJing95:fix/wiz-none-severity
Oct 23, 2026
Merged

mldangelo-oai merged 4 commits into
openai:mainfrom
WenJing95:fix/wiz-none-severity

Conversation

@WenJing95

@WenJing95 WenJing95 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Wiz vulnerability exports can report severity NONE. The importers currently reject that value, excluding otherwise valid findings. Import it as unknown so the finding is retained without assigning an informational severity.

ServiceNow's Wiz integration documentation describes NONE as no available severity values. Wiz's public vulnerability catalog also contains NONE records without a CVSS score; the value does not establish zero impact.

Changes

  • Map the selected none value to the existing unknown severity in the Wiz JSON and CSV adapters.
  • Keep severity-field precedence and original vendor evidence intact.
  • Cover JSON vendor/fallback severity and all three CSV severity columns, including raw JSON evidence preservation.

Testing

  • Wiz parsing/publication and local import suites: 219 tests passed, zero failures.
  • SDK production build and full SDK type checks passed.
  • SDK formatting and Markdown checks passed.
  • Before/after parser probes reproduced the original exclusions and verified the corrected mapping, existing valid severities, and continued rejection of unrecognized values.
  • Built the native host helper from the current source. Public CLI JSON and CSV imports into a synthetic local repository both succeeded; public CLI SQLite readback retained two unassessed records with unknown severity and the original NONE values.
  • git diff --check: passed.

Risk and rollout

Previously excluded NONE records will now be retained as unassessed evidence with unknown severity. No severity is inferred from numeric scores. The tests use synthetic local data; no production tenant was modified. Full hosted platform and package CI remains required before merge.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 23, 2026
@mldangelo-oai mldangelo-oai changed the title fix(wiz): import NONE severity vulnerabilities as informational fix(wiz): preserve unrated vulnerability severity on import Oct 23, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for identifying these excluded records. The import failure is real, but NONE does not establish an informational or zero-impact assessment. I adjusted both adapters to retain the finding with the existing unknown severity, preserving the selected field and original vendor evidence.

The repaired change passed 219 focused tests, SDK build/type/format checks, and actual CLI JSON/CSV imports with SQLite readback using a native helper built from current source. Independent review found no remaining blockers. Required hosted CI will be checked separately before merge.

@mldangelo-oai mldangelo-oai reopened this Oct 23, 2026
@mldangelo-oai mldangelo-oai reopened this Oct 23, 2026
@mldangelo-oai
mldangelo-oai merged commit 291ebf6 into openai:main Oct 23, 2026
120 of 123 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 24, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants