Repository navigation
fix(owners): match scan owner hints across email case variants - #1900
Merged
Merged
Conversation
mldangelo-oai
approved these changes
Oct 23, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for fixing this real owner-hint failure. I reproduced valid mixed-case hints failing on the parent revision and succeeding here, while unsupported hints still fail. The identity search stays tied to the cited Git commit, and the small predicate reuse is appropriate.
Verification passed: 67 focused tests, build/type/format checks, and seven cases through the built public SDK and actual post-scan owner-artifact path. Current-main integration passed too; canonical scan data stayed unchanged and no model calls were made. No remaining correctness issues found. Required hosted CI is running separately before merge.
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A valid scan owner hint can be reported as unsupported when Git history contains email spellings that differ only by case. The matcher previously selected the first case-insensitive identity before checking whether its evidence supports the cited commit.
Select the first matching identity that also has evidence for that commit, preserving the original Git identity and citation.
Changes
Testing
bun test --timeout 30000 tests-ts/suggest-owners.test.ts tests-ts/scan-owner-suggestions.test.ts: 67 passed, 214 assertions, zero failures.node --run build,pnpm run types, andpnpm run format: passed.Risk and rollout
This fixes an error in an optional owner-report row. Owner selection still requires matching Git evidence. The security scan and canonical findings are unaffected, and there is no public CLI change.
Public disclosure review