Repository navigation
fix(deep-scan): let reducers page inputs without code mode - #1910
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for fixing this. No blocking findings in this owner-level merge-safety pass. Both initial and resumed instructions now match the directly available reducer tools while retaining the code-mode path.
Verified a local scripted direct-tool run with five 480-byte pages, one successful submission, and intact source bodies and identities, plus focused coordinator, template and paging checks, typecheck, plugin build, and portable checks. The full coordinator suite is locally blocked by sandbox filesystem ownership; its seven isolated relevant cases pass. No live-model run was performed. Some Windows CI checks were still pending at review time.
Summary
Deep Scan reducers are told to use JavaScript code mode to read paged findings. In a fresh Codex 0.164.0 worker, code mode is off and the two reducer MCP tools are available directly. A reducer that follows the old instructions can finish its turn without writing a result, then receive the same instructions on retry.
Fixes #1865.
Changes
Explain how to follow each cursor, read the fragments in order, and submit the aggregate directly when code mode is unavailable. Apply the same guidance when a reducer resumes. Workers with code mode can continue using the existing pager to keep large documents inside a cell.
Testing
6696705319. The new regression failed against the original prompt and passed against both the initial and resumed prompts after the fix.Risk and rollout
This change affects the instructions sent to reducers. The direct path keeps input fragments in the model conversation, so the model's context window still bounds what it can process this way. The live-model smoke covered a small batch.
Public disclosure review