Repository navigation
fix(cli): show scan usage timestamps and account allowance - #1911
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f418361ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for adding live usage freshness and account allowance reporting. Owner-level merge-safety review of 9a75738: the package allowlist omission is fixed, but the existing terminal-height finding still reproduces. An 80-column, 12-row dashboard with three allowance readings renders 14 rows. Please fit the allowance section within the viewport while reserving the footer; this still needs attention before approval.
Validation: 278 portable cost, CLI, and dashboard tests passed (seed 12345), as did SDK types, formatting, plugin/package builds, the 743-entry archive contract check, and built CLI help. Synthetic receipt checks covered worker totals, missing timestamps, and allowance-only updates. The broader focused run had 302 passes and 65 failures involving local filesystem/Git fixtures; installed-package smoke also stopped at a Git fixture. A clean full integration suite is not claimed.
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for addressing the viewport feedback. No material findings in this owner-level merge-safety review of receipt accounting, SDK/component integration, CLI rendering, and packaging. The prior overflow is resolved: compact overview readings preserve the clock and budget controls, with complete readings available in Details. Account allowance remains separate from estimated-cost enforcement. Types, formatting, builds, archive validation, and 279 cost/CLI/dashboard tests passed. Independent checks covered 50 terminal configurations and nine receipt scenarios. Three direct-engine fixtures stopped at existing filesystem-owner checks, so a complete local integration pass remains unverified.
Summary
During a long scan, the elapsed clock kept moving while the dashboard displayed an unchanged cost with no measurement time. Codex could also report an account allowance before reporting any tokens, and the CLI dropped that reading. Saved scan history already records these measurements.
Fixes #29.
Changes
onUsageObservationcallback. The dashboard, text progress, and component scans use the same display formatting.Testing
6696705319with a synthetic 40-minute gap and a limit-only Codex event.b7fc1f791deb. They cover reported account windows, partial worker totals, missing timestamps, existing dollar limits, and a 48×16 terminal with eight account windows. A separate check exercised the overview, budget prompt, and Details across 20 terminal sizes.pnpm run types,pnpm run format, andgit diff --checkpassed. Started the full SDK suites with the default ordering and with seed12345.Risk and rollout
Live measurements use receipts from the scan's own sessions and workers. The observer reads the same incremental stream as cost tracking. Older runtimes can omit timestamps or account windows, and the CLI labels both cases. The existing
--max-costcheck continues to use the API-price estimate.Public disclosure review