Repository navigation
fix(action): validate generated files before rebuilding them - #1934
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for tightening the contributor workflow. No blocking findings in this owner-level merge-safety review: validation now checks committed generated files before rebuilding, and reversed reference markers fail without changing the README. On Node 24, all 177 Action tests, type checks, metadata, generated-documentation and bundle checks passed. Markdown formatting and both lockfile audits passed their high-severity threshold. I did not run the separate Linux CLI integration or smoke tests locally.
d650616 to
ca8dea2
Compare
Summary
The Action development guide rebuilt generated files before checking them, which could conceal a stale README or bundle in a checkout. Reversed reference markers also caused the generator to duplicate README content and exit successfully.
Changes
Testing
Risk and rollout
This change affects the contributor workflow and the local README generator. Ordered markers continue to produce the existing reference. Fix the order when the generator reports a malformed README. This PR is stacked on #1931.
Public disclosure review