Skip to content

fix(action): validate generated files before rebuilding them - #1934

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/action-validation-guide
Oct 25, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/action-validation-guide

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

The Action development guide rebuilt generated files before checking them, which could conceal a stale README or bundle in a checkout. Reversed reference markers also caused the generator to duplicate README content and exit successfully.

Changes

  • Run the same validation and lockfile audits as CI from the repository root. Document when to regenerate the input reference or rebuild the Action bundles.
  • Check the order of the reference markers before writing. Extend the existing generator fixture to verify that reversed markers fail and preserve the input file.

Testing

  • Reproduced the old generator duplicating the markers and surrounding text in an isolated README.
  • Node.js 24 Action validation passed all 177 tests, type checks, metadata validation, and generated README and bundle checks. Markdown formatting passed.
  • The focused SDK Action release suite passed all 55 tests.
  • Both npm audits passed their high-severity threshold. The Action lock reported zero advisories and the CLI lock reported three moderate advisories.
  • The pinned CLI integration and packaged Linux smoke test passed using Node.js 24 and a working sandbox.

Risk and rollout

This change affects the contributor workflow and the local README generator. Ordered markers continue to produce the existing reference. Fix the order when the generator reports a malformed README. This PR is stacked on #1931.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T00:56:34.770587Z ca8dea2 New commits
🔒 Security Review ✅ Completed 2026-10-25T00:57:07.159683Z ca8dea2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening the contributor workflow. No blocking findings in this owner-level merge-safety review: validation now checks committed generated files before rebuilding, and reversed reference markers fail without changing the README. On Node 24, all 177 Action tests, type checks, metadata, generated-documentation and bundle checks passed. Markdown formatting and both lockfile audits passed their high-severity threshold. I did not run the separate Linux CLI integration or smoke tests locally.

Base automatically changed from mdangelo/codex/ci-check-changed-components to main October 25, 2026 00:51
@github-actions github-actions Bot added the bug Something isn't working label Oct 25, 2026
@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/action-validation-guide branch from d650616 to ca8dea2 Compare October 25, 2026 00:55
@mldangelo-oai
mldangelo-oai merged commit 1b3eab1 into main Oct 25, 2026
43 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/action-validation-guide branch October 25, 2026 01:09
@github-actions github-actions Bot mentioned this pull request Oct 25, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants