Repository navigation
ci: verify merge parents after a pull request retarget - #1948
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks — no blocking findings in this owner-level merge-safety pass. Retargeted runs now stop before emitting selections when the checked-out merge parents differ from the event, and the existing aggregate gate propagates that failure. The change stays confined to the classifier and its fixture.
Validation: all 10 Node selection/gate tests and 19 focused Bun workflow/release tests passed (265 Bun assertions), along with SDK/MCP typechecking, changed-file formatting and whitespace checks. Reviewed both hosted retarget failures and their actual parent pairs. Full platform CI was not rerun locally.
Summary
Three pull request retargets started CI on a test merge whose first parent was still the previous base. In two of those cases, the checkout omitted changes from the requested target, including the shard runner in one case and the CI classifier in the other. Shard runner checkout · Classifier checkout
Changes
On a pull request retarget, compare the checked-out merge commit's ordered parents with the base and head SHAs in GitHub's event payload before selecting jobs. Report the requested base ref and both SHA pairs. A mismatch fails classification and propagates through the existing required gate.
Testing
Risk and rollout
A retarget with a stale checkout stops in the Linux classifier before the expensive jobs start. A new pull request event after GitHub refreshes the merge ref can test the updated tree. GitHub uses the original commit when rerunning an existing attempt. GitHub rerun documentation
Public disclosure review