Skip to content

test: check native Python reports in the Python matrix - #1950

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/ci-native-python-report-tests
Oct 25, 2026
Merged

mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/ci-native-python-report-tests

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Run the native Python report checks in the Python matrix. A Windows SDK shard reached its ten-second child deadline while starting the first of five interpreters. The expected missing-file failure appeared as a null exit status. This change is stacked on #1931. Windows job

Changes

  • Move the existing report parser into a script that the native macOS and Windows steps execute directly.
  • Exercise the same five inputs in a single pytest invocation on Linux, macOS, and Windows with Python 3.12. Each test uses its own temporary directory and a stale passing report beside the designated input.
  • Keep the fixture run separate from the plugin test command that produces the real native report. The SDK test checks the workflow command and its failure policy.

Testing

  • All five Python cases passed locally. Separate CLI executions returned the expected statuses for the missing, malformed, zero-case, skipped, and passing reports. Replaying native reports with 335 Windows and 398 macOS cases passed.
  • The five cases caught four mutations covering a stale input path, missing coverage, skipped coverage, and rejection of a valid report.
  • All 19 SDK skeleton tests passed with seed 15284. SDK types, SDK formatting, Python lint and formatting, and actionlint passed.

Risk and rollout

This affects repository CI. The native gate still reads reports/python.xml and fails on missing, malformed, empty, or skipped coverage. Reverting this commit restores the original workflow and SDK fixture.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T00:57:17.997077Z 21ec216 New commits
🔒 Security Review ✅ Completed 2026-10-25T00:57:50.125986Z 21ec216 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Owner-level merge-safety review is clean. Moving the fixtures into the Python matrix preserves the native report gate and removes the repeated SDK-launched interpreters. The Python cases, SDK skeleton tests, direct CLI checks, and workflow linting passed; the new fixture step also passed on all three hosted operating systems.

Base automatically changed from mdangelo/codex/ci-check-changed-components to main October 25, 2026 00:51
@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Oct 25, 2026
@mldangelo-oai
mldangelo-oai force-pushed the mdangelo/codex/ci-native-python-report-tests branch from eaed09a to 21ec216 Compare October 25, 2026 00:56

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Owner-level merge-safety review of 21ec216 is clean. The Python matrix now exercises the report gate without repeated SDK-launched interpreters, while the native jobs still require the designated nonempty report with no skipped cases. All five Python cases, five direct CLI cases, 19 SDK skeleton tests, types, formatting and workflow lint passed. The exact-head report-fixture step also passed on Linux, macOS and Windows CI. Full native/SDK suites were not rerun locally.

@mldangelo-oai
mldangelo-oai merged commit 65b96e8 into main Oct 25, 2026
82 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/ci-native-python-report-tests branch October 25, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants