Repository navigation
ci: select the mutation test runtime in one setup step - #1985
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for simplifying the runtime setup. This owner-level merge-safety pass found no blocking issues: all 14 resolved callers preserve their Node version, architecture, compilation condition, and cache paths, while the mutation job now selects Node 24.15.0 once.
Verified the frozen install and full three-module mutation trial on Node 24.15.0/Bun 1.3.14 (482 mutants: 286 killed, 196 survived, no errors or timeouts), all 24 CI selection/source/release-guide tests, configured actionlint/ShellCheck and zizmor, and diff checks. Hosted cache restoration and runner timing were not exercised locally.
Summary
The mutation job selected Node twice: once to set the version, then again to restore the pnpm cache. The shared setup can do both in one invocation.
Changes
Testing
git diff --check.Risk and rollout
This affects the internal CI composite. Its pnpm installer now starts from the hosted runner's initial npm in the mutation job, as it does in the other jobs; dependency installation and Stryker still use the exact chosen Node version. The workflow removes one action invocation. Elapsed-time savings have not been measured. The next scheduled mutation run will exercise the changed order on GitHub.
Public disclosure review