Repository navigation
ci: share the exact npm setup for release workflows - #1998
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for sharing the release npm setup and testing the actual workflow shell. This owner-level merge-safety review found no material issues. Both jobs now intentionally require npm 11.12.1 at the installed path in a fresh step before release operations; the helper is loaded from the matching trusted checkout and preserves the isolated install and provenance checks.
Validation passed: 380 release tests, 22 additional mock install/PATH cases, 16 CI-selection tests, the CI build, SDK/MCP typechecks, configured formatting, actionlint/ShellCheck, and configured zizmor. The mock cases include failed or missing installs, missing PATH handoff, wrong versions, and another executable reporting the correct version. No live registry install, publication, or release workflow was exercised.
Summary
The npm and GitHub release jobs installed the same npm version from the same registry, then checked the runner's PATH differently. Both jobs now require the executable they just installed before continuing. This also removes the second copy of the installer and the extra Node process that parsed the version in the npm release job.
Changes
GITHUB_PATHand verifies the selected executable in a separate step.Testing
Risk and rollout
The release jobs keep the same Node version, npm pin, registry, permissions, and provenance checks. If the runner selects a different npm after setup, the job now stops before any release command. Normal release timing is expected to be similar.
Public disclosure review