[sylvesterkaczmarek]

Summary

An explicitly selected Codex profile could not override a root approval_policy = "never" with "on-request". The SDK kept denying permission requests even though the selected profile requested automatic approval review. Resolve the selected profile first, consistent with model and provider settings. Fixes #528.

Changes

• Use the existing profile selector with a null-safe fallback to the root policy; no new resolver or public API.
• Preserve root behavior when the profile omits the policy or supplies null, which the TOML writer treats as absent.
• Cover both override directions, runtime configuration, thread options, saved recipes, and the intentional never override for fresh and resumed Deep Scan workers.
• Update the command-authentication test that still expected the old root-wins behavior.
• Document profile precedence and merge main 83564c957 into the branch.

Testing

Validated head 54ef007f1f2 against main 83564c957:

• 98 configuration, credential, Deep Scan configuration, and runtime-projection tests passed; five focused API/runtime approval cases also passed.
• Deep Scan executor suite passed, including concurrent discovery/reducer launches and resumed workers.
• SDK build, SDK/MCP types and generated-source checks, package formatting, Ruff checks, and plugin source compatibility checks passed.
• Negative controls reproduced the original override bug on main and the earlier patch's null-fallback regression.
• Broader tests are not clean: nine API cases and 26 CLI/config cases fail identically on main and this branch. Six saved-scan Python-discovery cases also reproduce on main. The full SDK run was stopped at these baseline failures; no complete SDK or cross-platform pass is claimed.

Risk and rollout

The behavior changes when an explicitly selected profile provides a policy that differs from the root. A selected on-request policy now enables automatic approval review even if the root says never. Missing or null profile values still inherit the root policy. Deep Scan workers retain their explicit never policy. No new CLI flags or dependencies.

Public disclosure review

• No customer, partner, prospect, or user identities, data, or identifying details are included.
• No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
• I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

[sylvesterkaczmarek]

Rebased onto current main today; the branch is now 0 behind and GitHub Verified. TypeScript build:ci passes, both focused approval-policy tests pass, Prettier is clean, and git diff --check passes. Could a maintainer review the refreshed head when convenient?

[sylvesterkaczmarek]

Could a maintainer approve CI and review the selected-profile approval-policy fix? There has been no review since the last refresh.

[mldangelo-oai]

Thanks for fixing this! Profile overrides now behave consistently with the other settings, and the fallback and Deep Scan worker cases are covered. All required checks passed.

The separate Invoice Desk smoke test stopped before running because its CI environment is missing an API key. That's unrelated to this change.