Repository navigation
feat(api): share OCI external-storage response types - #1164
Conversation
Castiron-Internal-PR: openai/openai-java-internal#242 Castiron-Source-SHA: 745ff2ca808f89805aa085b93818ce760cff2900 Castiron-Public-Base-SHA: 22bd97e
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 108 mixed files remain; 0 existing customizations changed. Compared 108 existing customizations unchanged
68 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38180505884 --repo openai/openai-java \
--name castiron-custom-code-38180505884-1 --dir /tmp/castiron-custom-code-38180505884-1
git apply --stat /tmp/castiron-custom-code-38180505884-1/custom-code.patch
cat /tmp/castiron-custom-code-38180505884-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 22bd97e2e62820dea1c5697cd75556623c5d2b9f 30b72a2d62d8f6e40a46e4d6764b1956cc254eb7
python3 scripts/castiron/custom_code_report.py report \
--base 22bd97e2e62820dea1c5697cd75556623c5d2b9f \
--head 30b72a2d62d8f6e40a46e4d6764b1956cc254eb7 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-30b72a2d62d8
cat /tmp/castiron-custom-code-30b72a2d62d8/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all five changed files at 30b72a2d62d8f6e40a46e4d6764b1956cc254eb7. No unintended correctness or maintainability findings.
Both response unions consistently use the shared OciExternalStorageProvider across builders, accessors, factories, Handler.onOci callbacks, and parsing. The model preserves field names, defaults, validation, raw values, and unknown-property storage. Request models and the other provider branches remain unchanged. The documented source and binary compatibility break is intentional; callers naming the removed response classes must migrate and recompile.
I verified the complete diff and pinned source hashes, with an independent source review. The added test checks standalone construction and round-trip equality; it does not exercise both union dispatch paths. I did not execute tests, builds, or generation.
At inspection, the current head had 12 successful, 2 skipped, and 2 running checks. The current-head OkTest compatibility run was still in progress.
2 participants
Summary
Expose one shared OCI provider response type for storage configurations and audit-log events.
Changes
Compatibility note
This intentionally replaces
ExternalStorageConfiguration.Provider.OciandAuditLogListResponse.ExternalStorageRegistered.Data.Provider.Ociwithcom.openai.models.admin.organization.externalstorage.OciExternalStorageProvider. Update imports, builders, explicit declarations, andHandler.onOci(...)callbacks to the shared type. Both provider unions'oci()/asOci()accessors andofOci(...)factories now use that model.The change gives configuration responses and audit events one consistent OCI response type, matching the other providers.
ExternalStorageCreateParams.Provider.Oci, request fields, and wire payloads are unchanged. The source and binary compatibility impact is accepted for this update; consumers should recompile after migrating explicit type references.