Skip to content

docs: clarify generated-file ownership - #1331

Merged
marcuswood-oai merged 2 commits into
mainfrom
codex/sdk-guidance-audit
Nov 4, 2026
Merged

marcuswood-oai merged 2 commits into
mainfrom
codex/sdk-guidance-audit

Conversation

@marcuswood-oai

Copy link
Copy Markdown
Contributor

Consolidate generated-file ownership guidance in the contributor guide and link to it from AGENTS.md. Explain how to trace a fix to the API schema, SDK generator, or a handwritten file, with a repository-specific example.

Verified the documentation links and section anchors and ran git diff --check.

@marcuswood-oai
marcuswood-oai requested a review from a team as a code owner November 3, 2026 21:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T22:37:06.292985Z 8f83a49 New commits
🔒 Security Review ✅ Completed 2026-11-03T22:37:21.257425Z 8f83a49 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after coordinator and independent static review of 136c4b9. Ownership guidance correctly routes schema, generator and handwritten fixes; BedrockAuth and example-directory ownership match the inventory. Links/anchors resolve, and the consolidated guidance preserves generated-output and inventory protections. No actionable findings. Hosted checks remain pending with no failures observed. No candidate code or local tests were executed.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 136c4b918e0571d7575583c25e9d70a8c6023893; no actionable findings. The consolidated ownership guidance preserves generated-file protections and correctly routes schema, generator and handwritten fixes. The Bedrock authentication helper and examples match the pinned inventory.

Checked both changed documents, links/anchors and pinned source ownership. Source-only; no local tests, generation or rendering checks ran. Hosted checks have no reported failures, with OkTest still pending.

@marcuswood-oai
marcuswood-oai added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@marcuswood-oai
marcuswood-oai added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit b5ee774 Nov 4, 2026
14 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants