Repository navigation
fix: preserve response headers on parsing and stream errors - #922
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df0e205eff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sylvesterkaczmarek
force-pushed
the
fix/exception-response-headers
branch
from
September 30, 2026 22:16
45e47a5 to
acb2462
Compare
Contributor
Author
|
I resolved this PR against current main while preserving the intended fix and newer upstream behavior. The branch is now mergeable and no longer has a base conflict. Could a maintainer please re-review it when convenient? @codex review |
Resolved against current stream shutdown handling.
sylvesterkaczmarek
force-pushed
the
fix/exception-response-headers
branch
from
October 1, 2026 08:29
acb2462 to
d037a18
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request preserves available HTTP response headers when response parsing or streaming fails, so callers can inspect diagnostics such as
x-request-id.Problem
OpenAIInvalidDataExceptionandOpenAIIoExceptioncurrently carry only a message and cause. This drops response metadata even in error paths where anHttpResponsealready exists:JsonHandlerwraps body read/deserialization failures asOpenAIInvalidDataException.StreamHandlerwraps readerIOExceptions asOpenAIIoException.That makes production debugging harder because callers cannot recover response headers such as
x-request-id.Changes
headers()accessors toOpenAIInvalidDataExceptionandOpenAIIoExceptionresponse.headers()when JSON body parsing failsCompatibility
The original primary constructor signatures and Kotlin default-argument ABI remain unchanged, and the existing Java overloads are preserved. The new header metadata is additive and optional.
Validation
mainat95f4a1173c119ad08a049d752ec67de251434938x-request-idpropagationFixes #690