Repository navigation
fix: settle WebSocket event waiters in linear time - #2389
Merged
Merged
Conversation
Contributor
jbeckwith-oai
approved these changes
Aug 18, 2026
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed exact head 5ea35a057674723f956c13aca14751871f297780 in two independent passes.
Both handwritten WebSocket emitters now settle concurrent event waiters in linear time while preserving nested dispatch snapshots, duplicate listeners, overridden hooks, arbitrary error identity, cleanup ordering, and the six public stable/beta transport variants. Focused 4,096-waiter success/error regressions and all Node 22/24/26, lint, build, ecosystem, performance, breaking-change, and security checks passed.
No findings.
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation