Skip to content

fix(examples): use the default audio recording input #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HAYDEN-OAI merged 1 commit into from
Sep 4, 2026
Merged

fix(examples): use the default audio recording input #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/audio/speech-to-text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const openai = new OpenAI();

async function main(): Promise<void> {
console.log('Recording for 5 seconds...');
const response = await recordAudio({ timeout: 5000, device: 4 });
const response = await recordAudio({ timeout: 5000 });

console.log('Transcribing...');
const transcription = await openai.audio.transcriptions.create({
Expand Down
16 changes: 11 additions & 5 deletions tests/lib/audio-example-exit-status.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ const audioTool = [
"const tool = require('node:path').basename(process.argv[1]);",
"const failed = process.env.AUDIO_TOOL_FAILURE === 'true';",
"if (tool === 'ffmpeg') {",
' fs.writeFileSync(process.env.AUDIO_TRACE, JSON.stringify({ tool }));',
' if (failed) process.exitCode = 47;',
" const input = process.argv[process.argv.indexOf('-i') + 1];",
' fs.writeFileSync(process.env.AUDIO_TRACE, JSON.stringify({ tool, input }));',
// Model a machine with only input zero available.
" if (failed || ![':0', 'hw:0'].includes(input)) process.exitCode = 47;",
" else process.stdout.write(Buffer.from(process.env.AUDIO_BYTES, 'hex'));",
'} else {',
' const chunks = [];',
Expand Down Expand Up @@ -160,9 +162,13 @@ describeOnUnix('audio executable examples', () => {
if (!recording && scenario === 'HTTP rejection') {
expect(existsSync(trace)).toBe(false);
} else {
expect(JSON.parse(await readFile(trace, 'utf-8'))).toEqual(
recording ? { tool: 'ffmpeg' } : { tool: 'ffplay', audio: audio.toString('hex') },
);
const recorded = JSON.parse(await readFile(trace, 'utf-8'));
if (recording) {
expect(recorded.tool).toBe('ffmpeg');
expect([':0', 'hw:0']).toContain(recorded.input);
} else {
expect(recorded).toEqual({ tool: 'ffplay', audio: audio.toString('hex') });
}
}
if (scenario === 'success') {
expect(result.stderr).toBe('');
Expand Down
Loading