Skip to content

feat(api): add shida to named Live voices - #4053

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-228
Oct 11, 2026
Merged

feat(api): add shida to named Live voices#4053
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-228

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds shida to the named built-in Live voices.

Changes

  • Expose shida in the built-in voice type while retaining all existing voice names and open-string inputs.

@jbeckwith-oai
feat(api): add shida to named Live voices
b237790 
Castiron-Internal-PR: openai/openai-python-internal#228
Castiron-Source-SHA: 385e0da619532b6c5d250049ea29699e663b8c4e
Castiron-Public-Base-SHA: c88b320
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 01:55
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 01:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T01:56:24.893383Z b237790 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T01:57:25.758296Z b237790 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: c88b32012ef0c3ebac39c79512994985a553a24c.

✅ No new custom-code files detected.

50 mixed files remain; 0 existing customizations changed.

Compared c88b32012ef0 → b2377903c15d. Generated baselines verified.

50 existing customizations unchanged
  • api.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/test_custom_code_github.py
  • scripts/castiron/test_custom_code_publication.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py

10 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38103457293 --repo openai/openai-python \
  --name castiron-custom-code-38103457293-1 --dir /tmp/castiron-custom-code-38103457293-1
git apply --stat /tmp/castiron-custom-code-38103457293-1/custom-code.patch
cat /tmp/castiron-custom-code-38103457293-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin c88b32012ef0c3ebac39c79512994985a553a24c b2377903c15db485969bc396064fc003f86f12ca
python3 scripts/castiron/custom_code_report.py report \
  --base c88b32012ef0c3ebac39c79512994985a553a24c \
  --head b2377903c15db485969bc396064fc003f86f12ca --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-b2377903c15d
cat /tmp/castiron-custom-code-b2377903c15d/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.542s for Python SDK PR #4053.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 218ms
tests/chat-completions-create.test.ts ✅ Passed 266ms
tests/chat-completions-stream.test.ts ✅ Passed 271ms
tests/files-content-binary.test.ts ✅ Passed 241ms
tests/files-create-multipart.test.ts ✅ Passed 230ms
tests/files-list-pagination.test.ts ✅ Passed 251ms
tests/initialize-config.test.ts ✅ Passed 206ms
tests/instance-isolation.test.ts ✅ Passed 217ms
tests/models-list.test.ts ✅ Passed 214ms
tests/responses-background-lifecycle.test.ts ✅ Passed 198ms
tests/responses-body-method-errors.test.ts ✅ Passed 312ms
tests/responses-cancel-timeout.test.ts ✅ Passed 235ms
tests/responses-cancel.test.ts ✅ Passed 191ms
tests/responses-compact-retries.test.ts ✅ Passed 335ms
tests/responses-compact.test.ts ✅ Passed 199ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 316ms
tests/responses-create-advanced.test.ts ✅ Passed 235ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.188s
tests/responses-create-errors.test.ts ✅ Passed 163ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 198ms
tests/responses-create-retries.test.ts ✅ Passed 233ms
tests/responses-create-stream-failures.test.ts ✅ Passed 855ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 235ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.152s
tests/responses-create-stream.test.ts ✅ Passed 135ms
tests/responses-create-terminal-states.test.ts ✅ Passed 245ms
tests/responses-create-timeout.test.ts ✅ Passed 231ms
tests/responses-create.test.ts ✅ Passed 228ms
tests/responses-delete.test.ts ✅ Passed 249ms
tests/responses-input-items-errors.test.ts ✅ Passed 535ms
tests/responses-input-items-list.test.ts ✅ Passed 359ms
tests/responses-input-items-options.test.ts ✅ Passed 264ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 272ms
tests/responses-input-tokens-count.test.ts ✅ Passed 196ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.177s
tests/responses-not-found-errors.test.ts ✅ Passed 257ms
tests/responses-parse.test.ts ✅ Passed 257ms
tests/responses-retrieve-retries.test.ts ✅ Passed 469ms
tests/responses-retrieve.test.ts ✅ Passed 234ms
tests/responses-stored-method-errors.test.ts ✅ Passed 502ms
tests/retry-behavior.test.ts ✅ Passed 3.034s
tests/sdk-error-shape.test.ts ✅ Passed 329ms

View OkTest run #38103442239

SDK merge (9ff394250b05) · head (b2377903c15d) · base (c88b32012ef0) · OkTest (57341bb8c17e)

markstuart-oai
markstuart-oai approved these changes Oct 11, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed b2377903c15db485969bc396064fc003f86f12ca. No actionable findings.

The BuiltInVoice literal adds shida and preserves all 22 prior names. Request models retain their string alternatives, so the named alias does not narrow the accepted input. The full API reference changes only the named voice enum. This follows the existing generated structure without adding complexity.

Source and static review only; I did not run repository tests or generation. The reported GitHub checks and external OkTest run passed.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 7352cf5 Oct 11, 2026
28 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-228 branch October 11, 2026 02:07
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes
@yoni-oai yoni-oai yoni-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbeckwith-oai @markstuart-oai @yoni-oai