Repository navigation
feat(authguest): renew and pin - #78
Conversation
| post: | ||
| tags: | ||
| - guestLinks | ||
| summary: "Alias for '/v1beta1/extensions/org.libregraph/guestLinks/redeem'" |
There was a problem hiding this comment.
That's actually a good point. /verify/token is exactly the same as /redeem request and response wise, so I don't think there's a good reason to keep them both, is there?
Unless I'm missing something I think it would be good to drop /redeem in favor of the verify one to simplify things. That would need changes in oc of course, maybe we could add that to opencloud-eu/opencloud#3667 while you're at it?
There was a problem hiding this comment.
I already added it to opencloud-eu/opencloud#3667, the reason why I added this alias was just that in different tickets it was named diferentlly, in some it was /redeem in some /verify/token
There was a problem hiding this comment.
Ah, yes. My point was to drop /redeem and just use /verify/token both for the initial and subsequent operations. That would simplify the API and I don't really see a downside, or am I missing something?
There was a problem hiding this comment.
agree, the only thing is if frontend team already started using /redeem endpoint they will need to change to /verify/token, but I believe this is not a big deal
| renew guest link: | ||
| value: | ||
| permissionId: d14f9f65-2e9b-4fd6-bf6b-6748f229f2a2 | ||
| responses: |
There was a problem hiding this comment.
401 is now another error response that can be returned when the credentials are wrong or missing, no?
| - shareExpired | ||
| - pinInvalid | ||
| - pinExpired | ||
| - serviceUnavailable |
There was a problem hiding this comment.
Hm, aren't we also missing the session_expired error here?
There was a problem hiding this comment.
we have sessionInvalid, would you like me to rename it to sessionExpired?
| post: | ||
| tags: | ||
| - guestLinks | ||
| summary: "Alias for '/v1beta1/extensions/org.libregraph/guestLinks/redeem'" |
There was a problem hiding this comment.
Ah, yes. My point was to drop /redeem and just use /verify/token both for the initial and subsequent operations. That would simplify the API and I don't really see a downside, or am I missing something?
3 participants
needed for #opencloud-eu/opencloud#3667