Repository navigation
Conversation
dschmidt
force-pushed
the
feat/thumbnail-content-type
branch
from
October 19, 2026 12:10
86fafbb to
3115e23
Compare
dschmidt
changed the title
dschmidt
force-pushed
the
feat/thumbnail-content-type
branch
from
October 19, 2026 12:25
3115e23 to
75eeaa9
Compare
dschmidt
changed the title
A thumbnail made from an image a file carries inside, audio cover art for one, keeps that image's type rather than whatever the file's type usually maps to. Without an annotation a client cannot know that before fetching the bytes.
dschmidt
marked this pull request as ready for review
October 19, 2026 12:37
dschmidt
requested review from
butonic,
dragotin,
fschade,
kulmann,
micbar and
rhafer
as code owners
October 19, 2026 12:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@libre.graph.mimeTypeto thethumbnailschema.A thumbnail is not always served in the type its item's type suggests. The case that forces this is an image a file carries inside: the cover art of an audio file is a png or a jpeg depending on the file, and the thumbnail keeps that type rather than being re-encoded. Without an annotation a client has to fetch the bytes to find out.
Microsoft Graph has no field for this: its thumbnail resource carries
content,height,sourceItemId,urlandwidthand says nothing about the type, hence the annotation. The name is Graph's own word for the concept,file.mimeType, which this spec already carries unprefixed: the type of some bytes, parsed, without the parameters aContent-Typeheader may bring along (Tika, for one, answerstext/plain; charset=windows-1252).Server side: opencloud-eu/opencloud#3210 indexes the embedded image's type and decides the served type from it; this annotation is how that reaches a client through
$expand=thumbnails.