Skip to content

feat(idp): configure trusted proxies via IDP_TRUSTED_PROXY #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fvlasie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(idp): configure trusted proxies via IDP_TRUSTED_PROXY #3540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/idp/pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ type Settings struct {

Insecure bool `yaml:"ldap_insecure" env:"OC_LDAP_INSECURE;IDP_INSECURE" desc:"Disable TLS certificate validation for the LDAP connections. Do not set this in production environments." introductionVersion:"1.0.0"`

TrustedProxy []string `yaml:"trusted_proxy"` //TODO: how to configure this via env?
TrustedProxy []string `yaml:"trusted_proxy" env:"IDP_TRUSTED_PROXY" desc:"A list of trusted proxy IP addresses or CIDR networks. When the request remote address matches, the IDP honors forwarded headers such as X-Forwarded-Proto. See the Environment Variable Types description for more details." introductionVersion:"%%NEXT%%"`

AllowScope []string `yaml:"allow_scope"` // TODO: is this even needed?
AllowClientGuests bool `yaml:"allow_client_guests" env:"IDP_ALLOW_CLIENT_GUESTS" desc:"Allow guest clients to access OpenCloud." introductionVersion:"1.0.0"`
Expand Down