Skip to content

feat: make space2share migration repeatable - #3669

Merged
micbar merged 2 commits into
mainfrom
share-migration-2
Oct 9, 2026
Merged

micbar merged 2 commits into
mainfrom
share-migration-2

Conversation

@micbar

@micbar micbar commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Description

Adds opencloud shares migrate to re-run a jsoncs3 share manager migration by name, whether or not it has run before.

Main use: opencloud shares migrate import_space_members re-imports the grants of every project space into the share manager, e.g. after space members were written as storage grants outside OpenCloud. The import is additive, so re-running it is safe.

  • --list shows the available migrations
  • --timeout limits the run (default 30m)

Builds on opencloud-eu/reva#864 (already in main via #3685).

@codacy-production

codacy-production Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 19 complexity

Metric Results
Complexity 19

View in Codacy

🟢 Coverage 0.00% diff coverage · -0.01% coverage variation

Metric Results
Coverage variation ✅ -0.01% coverage variation (-1.00%)
Diff coverage ✅ 0.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (84e10b3) 91169 22411 24.58%
Head commit (db4ad0f) 91247 (+78) 22423 (+12) 24.57% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3669) 85 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@micbar
micbar force-pushed the share-migration-2 branch from b293f6b to 20da8bf Compare October 8, 2026 09:39
@micbar

micbar commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

Needs opencloud-eu/reva#864

@micbar
micbar marked this pull request as ready for review October 8, 2026 09:45
Comment thread opencloud/pkg/command/shares.go Outdated
Comment thread opencloud/pkg/command/shares.go Outdated
Comment thread opencloud/pkg/command/shares.go
@micbar
micbar force-pushed the share-migration-2 branch from 20da8bf to db4ad0f Compare October 9, 2026 12:32
@micbar
micbar merged commit d1818a0 into main Oct 9, 2026
68 checks passed
@micbar
micbar deleted the share-migration-2 branch October 9, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants