Skip to content

fix: finetune contact invite error messages #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JammingBen merged 1 commit into from
Jun 11, 2026
Merged

fix: finetune contact invite error messages #2669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ export default defineComponent({
const saveQueue = new PQueue({ concurrency: unref(createSharesConcurrentRequests) })
const savePromises: Promise<void>[] = []
const errors: { displayName: string; error: Error }[] = []
const contactErrors: { displayName: string; error: Error }[] = []
const addedShares: CollaboratorShare[] = []
let invitedContactCount = 0

Expand All @@ -427,7 +428,7 @@ export default defineComponent({
invitedContactCount++
} catch (error) {
console.error(error)
errors.push({ displayName, error })
contactErrors.push({ displayName, error })
throw error
}
})
Expand All @@ -436,7 +437,6 @@ export default defineComponent({
}

const type = shareType === ShareTypes.group.value ? 'group' : 'user'

savePromises.push(
saveQueue.add(async () => {
try {
Expand Down Expand Up @@ -499,6 +499,14 @@ export default defineComponent({
errors: [e.error]
})
})
contactErrors.forEach((e) => {
showErrorMessage({
title: $gettext('Failed to send invite link for "%{displayName}"', {
displayName: e.displayName
}),
errors: [e.error]
})
})

expirationDate.value = null
selectedCollaborators.value = []
Expand Down
Loading