8379127: G1 does not properly consider existing surviving data when sizing Eden - #32599
Open
walulyai wants to merge 12 commits into
Open
8379127: G1 does not properly consider existing surviving data when sizing Eden#32599walulyai wants to merge 12 commits into
walulyai wants to merge 12 commits into
Conversation
|
👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
walulyai
marked this pull request as ready for review
September 1, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Please review this change, which reduces the likelihood of evacuation failures by considering the required evacuation space when sizing the young generation and selecting old CSet candidate groups.
Currently, G1 considers only predicted pause time when selecting old CSet regions for evacuation. This change extends the selection criteria to also account for predicted bytes to copy during evacuation.
A copy budget for old CSet candidates is derived after reserving space for young CSet evacuation. This budget applies to both candidates from marking and retained regions.
When selecting regions for optional collection, consider only the pause-time budget. Copy-space constraints are checked later, when optional regions are selected for evacuation.
We override both time and copy-space budgets to meet the required minimum old CSet size. Thus, the budgets only apply for additional selection after selecting the minimum regions required for evacuation progress.
Young-generation sizing is also refactored to use the same evacuation predictions: both pause time and bytes to copy. This reserves headroom for required evacuation work when sizing the young generation.
Testing: Mach5 Tiers 1-3
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32599/head:pull/32599$ git checkout pull/32599Update a local copy of the PR:
$ git checkout pull/32599$ git pull https://git.openjdk.org/jdk.git pull/32599/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32599View PR using the GUI difftool:
$ git pr show -t 32599Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32599.diff
Using Webrev
Link to Webrev Comment