Material info on right click#100
Merged
Merged
Conversation
paulromano
requested changes
Jul 6, 2022
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Love it! This will be very useful. A few suggested changes:
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
paulromano
approved these changes
Jul 6, 2022
Contributor
|
Thanks @kkiesling! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #80
If you right click on a material, clicking the material id from the menu will now open a message box with information about that material:
That was all the easily available information in
openmc.lib.materials, but let me know if there is other information that should be displayed.Also, I kind of think it'd be useful if the message box could stay open while using other parts of the gui, or if you could open multiple materials' information at the same time (ie multiple message boxes). But I couldn't figure out the proper way to do that with Qt. Right now, when the message box opens, you have to close it/press ok before doing anything more with the gui.