src folder and pyproject packaging#108
Closed
shimwell wants to merge 2 commits into
Closed
Conversation
Member
Author
|
this PR has some major merge conflicts since #110 was merged so I shall close it for now. If there is any interest in moving to a src folder layout for the package, updating the setup to use pyproject.toml or automatic the versioning with setuptools_scm give me a nudge and I can do this PR or aspects of it again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just seeing if the package could be updated to follow the latest python packaging recommendations https://packaging.python.org/en/latest/tutorials/packaging-projects/
3 benefits of src folder layout are detailed at the bottom of this page