Support opening single model XML files#115
Merged
Merged
Conversation
kkiesling
approved these changes
Apr 11, 2023
kkiesling
left a comment
kkiesling
left a comment
Contributor
There was a problem hiding this comment.
looks great. Thanks for this update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the plotter assumes that a user's model is always composed of separate geometry, materials, and settings XML files. This PR updates the plotter to work with our new functionality in v0.13.3 whereby a model can be represented in a single XML file. The command-line arguments were reconfigured now so that you pass the directory or model.xml file as a regular (non-flag) argument:
openmc-plotter(current directory with individual XML files or model.xml file)openmc-plotter some_dir/(directory with individual XML files or model.xml fileopenmc-plotter some_model.xml(single, arbitrarily named XML file)For consistency, the plot_settings.pkl file is always written in the same directory where the XML files exist.