Include puns colormaps#122
Merged
Merged
Conversation
paulromano
requested changes
Sep 13, 2023
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
I'm wary of relying on a function that is intended to be private (use of leading underscore). It looks like the same thing can be achieved with:
import matplotlib.pyplot as plt
plt.colormaps()
Contributor
Author
|
Right, I didn't realize that. I switched to those lines now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I noticed that the plotter does not allow for perceptually uniform sequential colormaps (e.g. viridis, cividis, plasma etc.). This PR includes them.
It was sufficient to substitute:
mcolormaps.datadwith:
mcolormaps._gen_cmap_registry()in docks.py and plotgui.py files.