Fix inconsistent model refresh threading#126
Merged
Merged
Conversation
paulromano
approved these changes
Oct 11, 2023
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! Also looks like the reload would have missed out on the model_path argument and I see you've included that too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
openmc-plotterwith the-sflag and specifying threads, this number would only be remembered for the first time loading the model. Any subsequent reloads called from the GUI would function as ifopenmc-plotterwere run with no thread specification, returning to the default value for that machine.This pull request adds a quick fix to enable any future loads/reloads of the model to use the number of threads as specified by the initial call of
openmc-plotter.