Skip to content

Fixes for DomainTableModel#159

Merged
paulromano merged 2 commits into
openmc-dev:developfrom
pshriwise:fix-domain-color-table
Oct 23, 2024
Merged

Fixes for DomainTableModel#159
paulromano merged 2 commits into
openmc-dev:developfrom
pshriwise:fix-domain-color-table

Conversation

@pshriwise

@pshriwise pshriwise commented Oct 22, 2024

Copy link
Copy Markdown
Collaborator

Fixes #156.

Issues addressed:

  • Qt.ItemFlag attributes no longer convert to int
  • Right-click to reset resulted in a None color value. It should now reset to the default color.

fnovais11
fnovais11 approved these changes Oct 22, 2024
View reviewed changes

@fnovais11 fnovais11 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thank you @pshriwise

paulromano
paulromano approved these changes Oct 23, 2024
View reviewed changes

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pshriwise!

@paulromano paulromano merged commit a96872c into openmc-dev:develop Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulromano paulromano paulromano approved these changes
+1 more reviewer
@fnovais11 fnovais11 fnovais11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trying to change material color in "Color Options..." menu does not work

3 participants

@pshriwise @paulromano @fnovais11